[Mlir-commits] [mlir] [mlir][linalg] Introduce transpose semantic to 'linalg.matmul' ops. (PR #104783)

[Renato Golin]

================
@@ -335,7 +412,7 @@ static void printNamedStructuredOp(OpAsmPrinter &p, Operation *op,
       /*elidedAttrs=*/{"operandSegmentSizes",
                        // See generated code in
                        // LinalgNamedStructuredOps.yamlgen.cpp.inc
-                       "linalg.memoized_indexing_maps"});
+                       "linalg.memoized_indexing_maps", "indexing_maps"});
----------------
rengolin wrote:

This seems to be reminiscent of the OpDSL mechanism. Changing the caller side may not be trivial without changing OpDSL itself, since the only call to this method (currently) is from inside `mlir-linalg-ods-yaml-gen.cpp`, and now from `matmul` in this PR.

We could just change the YAML generator with some default arguments, but we could also move the three matmuls and then refactor? We could also not reuse the same function, duplicate some of it elsewhere and leave the "NamedStructuredOp" stuff for OpDSL only.

I don't mind either way.

https://github.com/llvm/llvm-project/pull/104783