[Mlir-commits] [mlir] [mlir][linalg] Introduce transpose semantic to 'linalg.matmul' ops. (PR #104783)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 8 06:37:07 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 924a64a3486f9962c42d4ec253774eb2c586ac33 a88ca1a7bf7e9b04f41e91ece08f7c526abf9efa --extensions cpp -- mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp mlir/lib/Dialect/Linalg/Transforms/TransposeMatmul.cpp mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp mlir/lib/Dialect/NVGPU/TransformOps/NVGPUTransformOps.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
index a663b1c89a..be12b7797c 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
@@ -1166,7 +1166,8 @@ static bool isBroadcasted(AffineMap explictMap, AffineMap defaultMap) {
 /// Verifies the broadcast and transpose semantic sepecified by the explicit
 /// indexing map for the MatmulOp \p op for each operand specified by \p
 /// opIndex.
-static LogicalResult verifyExtendedMatmuSemantic(Operation *op, unsigned opIndex) {
+static LogicalResult verifyExtendedMatmuSemantic(Operation *op,
+                                                 unsigned opIndex) {
   MatmulOp matmulOp = dyn_cast<MatmulOp>(op);
   assert(matmulOp && "Expected linalg.matmul");
 
diff --git a/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp b/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
index 61c0a14c9c..e3f010d9cf 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
@@ -2074,7 +2074,7 @@ vectorizeScalableVectorPrecondition(Operation *op,
   // Check to not let go the matmul with extended semantic, through this
   // transform.
   if (linalgOp.hasUserDefinedMaps())
-      return failure();
+    return failure();
 
   // Cond 4: Only the following ops are supported in the
   // presence of scalable vectors

``````````

</details>


https://github.com/llvm/llvm-project/pull/104783


More information about the Mlir-commits mailing list