[Mlir-commits] [mlir] [MLIR] Don't drop attached discardable attributes (PR #111261)

[Mehdi Amini]

================
@@ -4337,11 +4337,16 @@ LogicalResult PackOp::canonicalize(PackOp packOp, PatternRewriter &rewriter) {
       dest =
           rewriter.create<tensor::CastOp>(loc, newDestType, packOp.getDest());
     }
-    Value newOp = rewriter.create<tensor::PackOp>(
-        loc, source, dest, packOp.getInnerDimsPos(), packOp.getMixedTiles(),
-        packOp.getPaddingValue(), packOp.getOuterDimsPerm());
+    auto clonedPackOp = cast<PackOp>(rewriter.clone(*packOp));
----------------
joker-eph wrote:

Shortest path should be:
```
  rewriter.modifyOpInPlace(packOp, [&] {
     packOp.getSourceMutable().assign(source);
     packOp.getDestMutable().assign(dest);
     packOp.getResult();.setType(dest.getType());
 });
```

https://github.com/llvm/llvm-project/pull/111261