[Mlir-commits] [mlir] [MLIR] Don't drop attached discardable attributes (PR #111261)

[Prashant Kumar]

pashu123 wrote:

> Nit: these aren't "custom" attributes, but "discardable" attributes, please update title and description.
> 
> Also, it's not clear to me why this is correct in the full generality: how do you know that the transformation isn't invalidating some of these attributes potentially?

I've updated the title. Thanks for the suggestion. This is not correct in full generality. For this patch, the only concern is `canonicalize` dropping the discardable attrs, which shouldn't be the case.

https://github.com/llvm/llvm-project/pull/111261