[Mlir-commits] [mlir] [MLIR] Update APInt construction to correctly set isSigned/implicitTrunc (PR #110466)

[Nikita Popov]

================
@@ -701,8 +701,10 @@ def Builtin_IntegerAttr : Builtin_Attr<"Integer", "integer",
         return $_get(type.getContext(), type, apValue);
       }
 
+      // TODO: Avoid implicit trunc?
       IntegerType intTy = ::llvm::cast<IntegerType>(type);
-      APInt apValue(intTy.getWidth(), value, intTy.isSignedInteger());
+      APInt apValue(intTy.getWidth(), value, intTy.isSignedInteger(),
+                    /*implicitTrunc=*/true);
----------------
nikic wrote:

Not familiar with MLIR, but probably by using a ctor that accepts APInt? That way you can explicitly specify that the constant needs to be sign extended.

Or possibly the code here should be setting signed=true for signless integers, as parameter is int64_t so signed value should be the default assumption?

https://github.com/llvm/llvm-project/pull/110466