[Mlir-commits] [mlir] [MLIR] Update APInt construction to correctly set isSigned/implicitTrunc (PR #110466)
Mehdi Amini
llvmlistbot at llvm.org
Mon Oct 7 07:10:44 PDT 2024
================
@@ -701,8 +701,10 @@ def Builtin_IntegerAttr : Builtin_Attr<"Integer", "integer",
return $_get(type.getContext(), type, apValue);
}
+ // TODO: Avoid implicit trunc?
IntegerType intTy = ::llvm::cast<IntegerType>(type);
- APInt apValue(intTy.getWidth(), value, intTy.isSignedInteger());
+ APInt apValue(intTy.getWidth(), value, intTy.isSignedInteger(),
+ /*implicitTrunc=*/true);
----------------
joker-eph wrote:
It seems strange we hit an issue here since we're passing the expected `isSigned` here right?
https://github.com/llvm/llvm-project/pull/110466
More information about the Mlir-commits
mailing list