[Mlir-commits] [mlir] [MLIR] Don't drop attached custom attributes (PR #111261)

Mehdi Amini llvmlistbot at llvm.org
Sun Oct 6 15:55:08 PDT 2024


joker-eph wrote:

Nit: these aren't "custom" attributes, but "discardable" attributes, please update title and description.

Also, it's not clear to me why this is correct in the full generality: how do you know that the transformation isn't invalidating some of these attributes potentially?

https://github.com/llvm/llvm-project/pull/111261


More information about the Mlir-commits mailing list