[Mlir-commits] [mlir] [MLIR] [AMX] Utilize x86_amx type for AMX dialect in MLIR. (PR #111197)

[Renato Golin]

================
@@ -258,6 +259,9 @@ class LLVMTypeConverter : public TypeConverter {
   /// Convert a 1D vector type into an LLVM vector type.
   FailureOr<Type> convertVectorType(VectorType type) const;
 
+  /// Convert AMX tile type x86_amx type.
+  Type convertAMXTileType(amx::TileType type) const;
----------------
rengolin wrote:

Hm, I see the chicken and egg problem here. Technically, the LLVM header should not include an AMX header, but the conversion is on an AMX type.

Perhaps the AMX tile type needs to be "lowered" to a vector type before it gets converted to LLVM's `X86_amx` type, but that's just odd.

Alternatively, since the `X86_amx` type is actually in LLVM itself, the type could be declared there, then you don't need to cross-include a higher level file.

https://github.com/llvm/llvm-project/pull/111197