[Mlir-commits] [mlir] [mlir][affine] fix the issue of celidiv mul ceildiv expression not satisfying commutative (PR #109382)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Oct 4 07:37:56 PDT 2024
================
@@ -349,6 +350,82 @@ unsigned AffineDimExpr::getPosition() const {
return static_cast<ImplType *>(expr)->position;
}
+/// A manually managed stack used to convert recursive function calls into
----------------
lipracer wrote:
Why don't use `walk`,
This is [walk](https://github.com/llvm/llvm-project/blob/bf488ed6e1fbe4c494a1dc0dd199a3d03405784e/mlir/include/mlir/IR/AffineExprVisitor.h#L163) implementation.At this point,`lhs` and `rhs` have already been traversed.and I don't know where to do the push stack.
https://github.com/llvm/llvm-project/pull/109382
More information about the Mlir-commits
mailing list