[Mlir-commits] [flang] [llvm] [mlir] [flang][OpenMP] Add frontend support for ompx_bare clause (PR #111106)
Sergio Afonso
llvmlistbot at llvm.org
Fri Oct 4 02:49:26 PDT 2024
https://github.com/skatrak commented:
The general approach to add the clause to the dialect looks good to me. One question I have is whether `ompx_bare` is only specifically supported for the combined `target teams` construct or if it can appear on a standalone `target`. If that's the case, I guess a semantics check for it would also be in order.
At the moment, the `num_teams_upper` and `thread_limit` arguments are defined as optional. I'm guessing they should become variadic and add some MLIR verification code to ensure the `ompx_bare` clause, `num_teams` and `thread_limit` are always in sync. Is that the plan or did you have something else in mind?
https://github.com/llvm/llvm-project/pull/111106
More information about the Mlir-commits
mailing list