[Mlir-commits] [mlir] [mlir][affine] fix the issue of celidiv mul ceildiv expression not satisfying commutative (PR #109382)

Johannes Reifferscheid llvmlistbot at llvm.org
Fri Oct 4 02:44:41 PDT 2024


================
@@ -349,6 +350,82 @@ unsigned AffineDimExpr::getPosition() const {
   return static_cast<ImplType *>(expr)->position;
 }
 
+/// A manually managed stack used to convert recursive function calls into
----------------
jreiffers wrote:

Yeah, I'm aware you need an explicit stack. I'm just asking why AffineExpr::walk won't do the trick. It seems to me like it should. Generally, it's better to use existing infrastructure if possible. 

https://github.com/llvm/llvm-project/pull/109382


More information about the Mlir-commits mailing list