[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: No rollback during analysis conversion (PR #106414)

[Matthias Springer]

matthias-springer wrote:

> This looks good given large goal - this does make analysis more conservative I believe (e.g., wouldn't try alternative ways by rolling back and attempting another approach). But as goal is to remove rollback this is a temporary difference.

Thx, the analysis actually isn't changing. We still roll back and try alternative ways. The only difference is that at the end of the analysis conversion, we don't roll back the changes that were "committed". Instead, the entire analysis conversion operates on a copy of the IR and we delete the copy instead of rolling back. (But during the analysis conversion, there can still be rollbacks on the copy.)



https://github.com/llvm/llvm-project/pull/106414