[Mlir-commits] [mlir] [mlir][linalg] Introduce transpose semantic to 'linalg.matmul' ops. (PR #104783)

[llvmlistbot at llvm.org]

================
@@ -149,15 +154,41 @@ static void fillStructuredOpRegion(OpBuilder &opBuilder, Region &region,
   // iterator_types is an auto-generated method.
 }
 
+/// Helper to create a typical indexing map for MatmulOp. Returns a list of
+/// AffineMap.
+static SmallVector<AffineMap, 3>
----------------
MaheshRavishankar wrote:

I'd strongly suggest dropping the `, 3` here and everywhere. That results in spooky copies if the caller does not use `SmallVector<AffineMap, 3>` and uses `SmallVector<AffineMap>` instead. Less confusion for a few extra stack elements is OK I think.

https://github.com/llvm/llvm-project/pull/104783