[Mlir-commits] [mlir] [mlir][linalg] Introduce transpose semantic to 'linalg.matmul' ops. (PR #104783)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

Thanks, I left some more comments. It would really help if you add some comments about how a comment was resolved when resolving it. 

Overall I think there needs to be better specification for the methods added to `MatmulOp`. There seems to be some implicit assumption of how these methods are to be called and it isnt clear at all what that expectation is. It might be easiest to just say `isLhsTransposed`, `isRhsTransposed`, `isLhsBroadcasted`... etc. The different methods that just take an `explcitiMap` and a `defaultMap` are very hard to follow.

https://github.com/llvm/llvm-project/pull/104783