[Mlir-commits] [llvm] [mlir] adds missing header, removes Bazel unnecessary dependency (PR #110932)

Christopher Di Bella llvmlistbot at llvm.org
Wed Oct 2 15:11:55 PDT 2024


https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/110932

>From ae4a3b96d0564d7f928ac96b7c42ee30dc117402 Mon Sep 17 00:00:00 2001
From: Christopher Di Bella <cjdb at google.com>
Date: Wed, 2 Oct 2024 21:43:55 +0000
Subject: [PATCH 1/3] adds missing header, removes Bazel unnecessary dependency

---
 .../Affine/IR/ValueBoundsOpInterfaceImpl.h    |  1 +
 .../llvm-project-overlay/mlir/BUILD.bazel     | 21 ++++++++++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
index 451c466fa0c950..51831cb17992ac 100644
--- a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
+++ b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
@@ -9,6 +9,7 @@
 #ifndef MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 #define MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 
+#include <cstdint>
 #include "mlir/Support/LLVM.h"
 
 namespace mlir {
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 8340e25352a355..596cecdf2c2ac2 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -3749,10 +3749,10 @@ cc_library(
         ":BytecodeOpInterface",
         ":DialectUtils",
         ":IR",
+        ":MaskableOpInterface",
         ":ShapedOpInterfaces",
         ":SideEffectInterfaces",
         ":VectorDialect",
-        ":VectorOpsIncGen",
         ":ViewLikeInterface",
         ":XeGPUEnumsIncGen",
         ":XeGPUIncGen",
@@ -11719,6 +11719,25 @@ gentbl_cc_library(
     ],
 )
 
+cc_library(
+    name = "VectorOps",
+    hdrs = [
+        "include/mlir/Dialect/Vector/IR/VectorAttributes.h.inc",
+        "include/mlir/Dialect/Vector/IR/VectorDialect.h.inc",
+        "include/mlir/Dialect/Vector/IR/VectorEnums.h.inc",
+        "include/mlir/Dialect/Vector/IR/VectorOps.h",
+    ],
+    includes = ["include"],
+    deps = [
+        ":ArithDialect",
+        ":BytecodeOpInterface",
+        ":MaskableOpInterface",
+        ":VectorAttributesIncGen",
+        ":VectorDialectIncGen",
+        ":VectorOpsIncGen",
+    ],
+)
+
 gentbl_cc_library(
     name = "VectorAttributesIncGen",
     tbl_outs = [

>From 394db8b1103d9151f35a33103de64ba93f526d7e Mon Sep 17 00:00:00 2001
From: Christopher Di Bella <cjdb.ns at gmail.com>
Date: Wed, 2 Oct 2024 14:50:28 -0700
Subject: [PATCH 2/3] Update utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

---
 .../llvm-project-overlay/mlir/BUILD.bazel     | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 596cecdf2c2ac2..36a9752d580b35 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -11719,25 +11719,6 @@ gentbl_cc_library(
     ],
 )
 
-cc_library(
-    name = "VectorOps",
-    hdrs = [
-        "include/mlir/Dialect/Vector/IR/VectorAttributes.h.inc",
-        "include/mlir/Dialect/Vector/IR/VectorDialect.h.inc",
-        "include/mlir/Dialect/Vector/IR/VectorEnums.h.inc",
-        "include/mlir/Dialect/Vector/IR/VectorOps.h",
-    ],
-    includes = ["include"],
-    deps = [
-        ":ArithDialect",
-        ":BytecodeOpInterface",
-        ":MaskableOpInterface",
-        ":VectorAttributesIncGen",
-        ":VectorDialectIncGen",
-        ":VectorOpsIncGen",
-    ],
-)
-
 gentbl_cc_library(
     name = "VectorAttributesIncGen",
     tbl_outs = [

>From 25604577ad264945779703430f870496df4700db Mon Sep 17 00:00:00 2001
From: Christopher Di Bella <cjdb.ns at gmail.com>
Date: Wed, 2 Oct 2024 15:11:47 -0700
Subject: [PATCH 3/3] Update ValueBoundsOpInterfaceImpl.h

---
 .../include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
index 51831cb17992ac..642e99d963ef61 100644
--- a/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
+++ b/mlir/include/mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h
@@ -9,8 +9,8 @@
 #ifndef MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 #define MLIR_DIALECT_AFFINE_IR_VALUEBOUNDSOPINTERFACEIMPL_H
 
-#include <cstdint>
 #include "mlir/Support/LLVM.h"
+#include <cstdint>
 
 namespace mlir {
 class DialectRegistry;



More information about the Mlir-commits mailing list