[Mlir-commits] [mlir] [MLIR][Linalg] Pattern to fold AddOp to accumulation via contraction op's dest (PR #110514)

[Andrzej Warzyński]

https://github.com/banach-space commented:

The helpers that you added in Linalg/Utils/Utils.h are not really specific to Linalg and should be moved to somewhere more general. Given the [location](StaticValueUtils.h) of `isZeroIndex`, I suggest StaticValueUtils.h. Also, it feels like some of the logic that you added there should already exist 🤔 

I also suggest bailing out early when encountering memrefs. Unless that's something that this is meant to support?

https://github.com/llvm/llvm-project/pull/110514