[Mlir-commits] [mlir] [mlir][vector] Add memref reshapes to transfer flow opt (PR #110521)

Quinn Dawkins llvmlistbot at llvm.org
Tue Oct 1 20:50:51 PDT 2024


qedawkins wrote:

> LGTM, thank you and sorry for the delay!

This seemed to me like a pretty fast turnaround for review, thanks!

> > in general still don't properly account for other potential aliasing ops or non-transfer read/write ops
> 
> I guess that `ViewLikeOpInterface` should be sufficient, right?

`ViewLikeOpInterface` is certainly better (I feel much more comfortable with this at least) but it's still possible to have aliasing not captured here (e.g. multiple memref function arguments, operands of (S)CF ops) so perhaps still use with some caution.

https://github.com/llvm/llvm-project/pull/110521


More information about the Mlir-commits mailing list