[Mlir-commits] [mlir] [mlir-python] Emit only dialect `EnumAttr` registrations. (PR #117918)

Maksim Levental llvmlistbot at llvm.org
Wed Nov 27 16:15:15 PST 2024


makslevental wrote:

> The other is also that these should be prefixed with dialect. Problem 2 is resolved by requiring folks to prefix with namespace as is done most places.

Yes but it's upstream where the problem lies in that there are many attributes that are in builtin and aren't prefixed. Such as all these in [linalg](https://github.com/llvm/llvm-project/blob/e7d09cecc9123f89ace1712a617e252d78b179e9/mlir/include/mlir/Dialect/Linalg/IR/LinalgEnums.td#L19) and [FastMathFlags](https://github.com/llvm/llvm-project/blob/4a7b56e6e7dd0f83c379ad06b6e81450bc691ba6/mlir/include/mlir/Dialect/Arith/IR/ArithBase.td#L118) in arith.

https://github.com/llvm/llvm-project/pull/117918


More information about the Mlir-commits mailing list