[Mlir-commits] [flang] [mlir] [mlir][OpenMP] Annotate `private` vars with `map_idx` when needed (PR #116770)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Nov 27 08:00:52 PST 2024
https://github.com/agozillon approved this pull request.
This LGTM, I think the approach is reasonable, especially as you've tried the other suggestions.
However, it might be worth checking if the additional map arguments affect the block argument interface API at all that can be used to retrieve the correct block argument offset vs map arguments, we utilise this to know the correct grouping of map containing clause operations <-> block arguments for TargetOp/TargetDataOp. I don't think it will, but even if private variables don't need block arguments there may be a small chance it disturbs the ordering, @skatrak will more than likely be able to say one way or another! :-)
https://github.com/llvm/llvm-project/pull/116770
More information about the Mlir-commits
mailing list