[Mlir-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Improve docs for materializations (PR #117847)
Markus Böck
llvmlistbot at llvm.org
Wed Nov 27 00:41:00 PST 2024
================
@@ -252,16 +252,15 @@ depending on the situation.
conversion. (E.g., adaptors support only a single replacement value for
each original value.) Therefore, an argument materialization is used to
convert potentially multiple new block arguments back into a single SSA
- value.
+ value. An argument materialization is also used when replacing an op
+ result with multiple values.
* Source Materialization
- - A source materialization converts from a value with a "legal" target
- type, back to a specific source type. This is used when an operation is
- "legal" during the conversion process, but contains a use of an illegal
- type. This may happen during a conversion where some operations are
- converted to those with different resultant types, but still retain
- users of the original type system.
+ - A source materialization is used when a value was replaced with a value
+ of different type, but there are still users that expects the original
----------------
zero9178 wrote:
```suggestion
of a different type, but there are still users that expects the original
```
https://github.com/llvm/llvm-project/pull/117847
More information about the Mlir-commits
mailing list