[Mlir-commits] [mlir] [mlir][bufferization] Remove remaining dialect conversion-based infra parts (PR #114155)
Matthias Springer
llvmlistbot at llvm.org
Tue Nov 26 16:31:19 PST 2024
matthias-springer wrote:
> LGTM. I am thinking whether it would be helpful if you mention somewhere (Bufferize.h) about the old-bufferizer; also, why type-converter was there and no longer needed etc. When people run into errors (or discover that their merge fails) the comment might give them some guidance.
They are going to find this commit during the integrate. The commit message should be enough. That's why I put `Note for LLVM integration: ...` into all commit messages. I think other than "copy it if you need it", there's not much more to say.
https://github.com/llvm/llvm-project/pull/114155
More information about the Mlir-commits
mailing list