[Mlir-commits] [mlir] [MLIR] Removing dead values for branches (PR #117501)

[M. Zeeshan Siddiqui]

================
@@ -563,6 +575,48 @@ static void cleanRegionBranchOp(RegionBranchOpInterface regionBranchOp,
   dropUsesAndEraseResults(regionBranchOp.getOperation(), resultsToKeep.flip());
 }
 
+// 1. Iterate over each successor block of the given BranchOpInterface
+// operation.
+// 2. For each successor block:
+//    a. Retrieve the operands passed to the successor.
+//    b. Use the provided liveness analysis (`RunLivenessAnalysis`) to determine
+//    which
+//       operands are live in the successor block.
+//    c. Mark each operand as live or dead based on the analysis.
+// 3. Remove dead operands from the branch operation and arguments accordingly
+
+static void cleanBranchOp(BranchOpInterface branchOp, RunLivenessAnalysis &la) {
----------------
codemzs wrote:

I think this needs to be a recursive solution, you can have the same situation in a nested conditional branch, for example with in a branch you could declare variables and then pass them to the nested conditional branch in this case it won't be part of your successor block arguments. 

https://github.com/llvm/llvm-project/pull/117501