[Mlir-commits] [mlir] [MLIR][Affine] Update ::fold() to have constant basis attr for affine.delinearize_index/linearize_index wherever applicable (PR #117572)

Krzysztof Drewniak llvmlistbot at llvm.org
Tue Nov 26 09:19:43 PST 2024


https://github.com/krzysz00 commented:

Could you double-check the requirements on `fold()`. I have the vague sense that if you mutated the operation you need to return the results of the operation you just mutated.

(Also, it might be a better move to look through the dynamic basis for constants and, if you find any non-null `Attribute`s, to go swap them in at the right spot)

https://github.com/llvm/llvm-project/pull/117572


More information about the Mlir-commits mailing list