[Mlir-commits] [mlir] [GPU] ASAN failure due to use of erased operation (PR #116816)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

Take the downstream tests that triggered the asan issue, minimize it by removing downstream-specific parts, and put it somewhere it can run. Ideally, it would be a "unit test", i.e, a `.mlir` file running one pass and checking the output. Many MLIR integrators are running all tests under asan and would have seen the failure had it had the corresponding test.

Regardless of that, the change itself looks off to me. It calls `replaceUnitMappingIdsHelper` on the parent block of a target, which breaks the fundamental assumption of the transform dialect (and passes by the way, imaging target is the root operation of the interpreter pass).

https://github.com/llvm/llvm-project/pull/116816