[Mlir-commits] [mlir] [MLIR][NFC] Add allow Insert/extract slice option to pack/unpack op (PR #117340)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Nov 25 06:57:27 PST 2024


Max191 wrote:

> On a different note, there's `lower{Un}Pack` and there's `DecomposeOuterUnitDimsPackOpPattern`. We should unify these things at some point.

I agree it is good to unify and reduce the overall number of patterns, but just want to note that we should make sure we still have control over how the patterns are applied (that's probably what you were suggesting anyway, but just wanted to add that comment).

https://github.com/llvm/llvm-project/pull/117340


More information about the Mlir-commits mailing list