[Mlir-commits] [mlir] [MLIR][NFC] Add allow Insert/extract slice option to pack/unpack op (PR #117340)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Nov 25 06:32:21 PST 2024


banach-space wrote:

> Under such circumstances, such insert and extract slice ops will block producer/consumer fusion tile + fuse transforms. With this PR, we will be able to disable such lowering path and allow consumer fusion to go through as expected.

Why not add tests for that? I don't really know how fusion is tested, but this summary implies that we should be writing tests showing how these things compose? And demonstrating the impact of this new flag.

On a different note, there's `lower{Un}Pack` and there's `DecomposeOuterUnitDimsPackOpPattern`. We should unify these things at some point.

https://github.com/llvm/llvm-project/pull/117340


More information about the Mlir-commits mailing list