[Mlir-commits] [mlir] [mlir][vector] Rename vector type TD definitions (nfc) (PR #117150)

[Kunwar Grover]

https://github.com/Groverkss approved this pull request.

This change by itself is good.

But another suggestion based on problems I've had with these tablegen defs: AnyVector not allowing 0-d rank vectors is a bit confusing. AnyVector is really AnyVectorOfAnyRank + additional constraints. It took some debug time in the past to figure out that the naming is weird. The naming should maybe be AnyVectorOfNonZeroRank and AnyVector, or even AnyVectorOfNonZeroRank and AnyVectorOfAnyRank, to better reflect that the current AnyVector is more constrainted definition. What do you think? (My suggestion is non blocking, feel free to land)



https://github.com/llvm/llvm-project/pull/117150