[Mlir-commits] [mlir] [mlir][scf]: Define scf.for lower/upper bounds can be also negative or zero (nfc) (PR #117534)

Aviad Cohen llvmlistbot at llvm.org
Mon Nov 25 02:11:12 PST 2024


https://github.com/AviadCo updated https://github.com/llvm/llvm-project/pull/117534

>From 8e49c017976af77f01254d462cfdaecb9d0650fe Mon Sep 17 00:00:00 2001
From: Aviad Cohen <aviad.cohen2 at mobileye.com>
Date: Mon, 25 Nov 2024 12:05:47 +0200
Subject: [PATCH] [nfc[[mlir][scf]: Define scf.for lower/upper bounds can be
 also negative or zero

Per the discussion here: https://github.com/llvm/llvm-project/pull/116748#discussion_r1848680070 , this commit properly declare that lower and upper bounds can be also negative or zero.
---
 mlir/include/mlir/Dialect/SCF/IR/SCFOps.td | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
index 361f8e0cf79ec6..64fa2df2431c71 100644
--- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
+++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
@@ -153,9 +153,10 @@ def ForOp : SCF_Op<"for",
     operation defines an SSA value for its induction variable. It has one
     region capturing the loop body. The induction variable is represented as an
     argument of this region. This SSA value is a signless integer or index.
-    The step is a value of same type but required to be positive. The lower and
-    upper bounds specify a half-open range: the range includes the lower bound
-    but does not include the upper bound.
+    The step is a value of same type but required to be positive, the lower and
+    upper bounds can be also negative or zero. The lower and upper bounds specify
+    a half-open range: the range includes the lower bound but does not include
+    the upper bound.
 
     The body region must contain exactly one block that terminates with
     `scf.yield`. Calling ForOp::build will create such a region and insert



More information about the Mlir-commits mailing list