[Mlir-commits] [mlir] Allow SymbolUserOpInterface operators to be used in RemoveDeadValues Pass (PR #117405)

Mehdi Amini llvmlistbot at llvm.org
Sat Nov 23 08:34:17 PST 2024


================
@@ -3,9 +3,10 @@
 // The IR is updated regardless of memref.global private constant
 //
 module {
-  memref.global "private" constant @__something_global : memref<i32> = dense<0>
+  memref.global "private" constant @global_buffer : memref<5xi32> = dense<[1, 2, 3, 4, 5]> : tensor<5xi32>
   func.func @main(%arg0: i32) -> i32 {
     %0 = tensor.empty() : tensor<10xbf16>
+    %1 = memref.get_global @global_buffer : memref<5xi32>
----------------
joker-eph wrote:

The existing test is explicitly checking that the `tensor.empty` op is removed:
```
    // CHECK-NOT: tensor.empty
```

Right now you're not testing the expectation that the get_global op is removed, so I would add:

```
    // CHECK-NOT: memref.get_global
```

https://github.com/llvm/llvm-project/pull/117405


More information about the Mlir-commits mailing list