[Mlir-commits] [mlir] [mlir][vector] Add verification for incorrect vector.extract (PR #115824)

Jakub Kuderski llvmlistbot at llvm.org
Fri Nov 22 08:41:38 PST 2024


kuhar wrote:

I referred to SPIR-V not having 1-element vectors. When converting to SPIR-V, this causes extra complexity because the type converter will return scalars for original operands/results of vector type.

You can see a bunch of examples by searching for `isa<spirv::ScalarType>` in https://github.com/llvm/llvm-project/blob/main/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp. (There are other ways to write this check (scattered around the surrounding infrastructure), so this search won't be exhaustive.)

https://github.com/llvm/llvm-project/pull/115824


More information about the Mlir-commits mailing list