[Mlir-commits] [mlir] 454398a - [MLIR] Add missing memory read effect on memref.reshape (#117130)

[llvmlistbot at llvm.org]

Author: Uday Bondhugula
Date: 2024-11-22T07:54:54+05:30
New Revision: 454398ab04e2cd773a4b264433eb841e8cec0470

URL: https://github.com/llvm/llvm-project/commit/454398ab04e2cd773a4b264433eb841e8cec0470
DIFF: https://github.com/llvm/llvm-project/commit/454398ab04e2cd773a4b264433eb841e8cec0470.diff

LOG: [MLIR] Add missing memory read effect on memref.reshape (#117130)

The memory read effect on a memref.reshape argument was missing. This in
turn led to
analyses relying on memory effects making incorrect conclusions.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
index c50df6ccd9aa56..a0d8d34f38237a 100644
--- a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
+++ b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
@@ -1529,7 +1529,8 @@ def MemRef_ReshapeOp: MemRef_Op<"reshape", [
   }];
 
   let arguments = (ins AnyRankedOrUnrankedMemRef:$source,
-                       MemRefRankOf<[AnySignlessInteger, Index], [1]>:$shape);
+                       Arg<MemRefRankOf<[AnySignlessInteger, Index], [1]>,
+                       "dynamically-sized shape", [MemRead]>:$shape);
   let results = (outs AnyRankedOrUnrankedMemRef:$result);
 
   let builders = [OpBuilder<