[Mlir-commits] [mlir] [mlir][vector] Add verification for incorrect vector.extract (PR #115824)

[Andrzej Warzyński]

================
@@ -234,12 +234,22 @@ func.func @extract_val_idx(%arg0: vector<4x8x16xf32>, %idx: index)
 }
 
 // CHECK-LABEL: @extract_0d
-func.func @extract_0d(%a: vector<f32>) -> f32 {
-  // CHECK-NEXT: vector.extract %{{.*}}[] : f32 from vector<f32>
-  %0 = vector.extract %a[] : f32 from vector<f32>
+func.func @extract_0d(%arg0: vector<f32>) -> f32 {
+  //      CHECK: vector.extract %{{.*}}[] : f32 from vector<f32>
+  %0 = vector.extract %arg0[] : f32 from vector<f32>
   return %0 : f32
 }
 
+// CHECK-LABEL: @extract_1d
+func.func @extract_1d(%arg0: vector<1xf32>, %arg1: vector<4x1xf32>)
+                      -> (f32, vector<1xf32>) {
+  //      CHECK: vector.extract %{{.*}}[0] : f32 from vector<1xf32>
+  %0 = vector.extract %arg0[0] : f32 from vector<1xf32>
+  // CHECK-NEXT: vector.extract %{{.*}}[2] : vector<1xf32> from vector<4x1xf32>
+  %1 = vector.extract %arg1[2] : vector<1xf32> from vector<4x1xf32>
+  return %0, %1 : f32, vector<1xf32>
+}
+
----------------
banach-space wrote:

Shouldn't these two match `@insert_0d` and `@insert_1d`, respectively, in terms of cases being exercised?

https://github.com/llvm/llvm-project/pull/115824