[Mlir-commits] [mlir] [mlir][Transforms] Add 1:N `matchAndRewrite` overload (PR #116470)

Ingo Müller llvmlistbot at llvm.org
Thu Nov 21 02:52:34 PST 2024


================
@@ -37,7 +37,8 @@ struct CallOpSignatureConversion : public OpConversionPattern<CallOp> {
     // Substitute with the new result types from the corresponding FuncType
     // conversion.
     rewriter.replaceOpWithNewOp<CallOp>(
-        callOp, callOp.getCallee(), convertedResults, adaptor.getOperands());
+        callOp, callOp.getCallee(), convertedResults,
+        getOneToOneAdaptorOperands(adaptor.getOperands()));
----------------
ingomueller-net wrote:

Why do we use `getOneToOneAdaptorOperands` here? I'd have expected `flattenValues` (or whatever it's called). I haven't thought about this for a particularly long time, so I might have missed something obvious. If not: why wasn't this caught by the tests?

https://github.com/llvm/llvm-project/pull/116470


More information about the Mlir-commits mailing list