[Mlir-commits] [mlir] [mlir][vector] Add more tests for ConvertVectorToLLVM (10/n) (PR #117041)

Andrzej WarzyƄski llvmlistbot at llvm.org
Thu Nov 21 01:27:01 PST 2024


================
@@ -3042,13 +3042,13 @@ func.func @vector_store_index_scalable(%memref : memref<200x100xindex>, %i : ind
 
 // -----
 
-func.func @vector_store_op_0d(%memref : memref<200x100xf32>, %i : index, %j : index) {
+func.func @vector_store_0d(%memref : memref<200x100xf32>, %i : index, %j : index) {
----------------
banach-space wrote:

Thanks for pointing this out!

There's actually more inconsistencies in this file, e.g. 
* `@vector_store_0d` vs `@scatter_index` (i.e. `@vector_{op_name}_{variant}` vs `@{op_name}_{variant}`.  

I was planning to send a dedicated refactor patch at the end :)

https://github.com/llvm/llvm-project/pull/117041


More information about the Mlir-commits mailing list