[Mlir-commits] [flang] [mlir] [mlir][OpenMP] Annotate `private` vars with `map_idx` when needed (PR #116770)

[Kareem Ergawy]

ergawy wrote:

> Does this have to be an index? What if this was modeled as another reference to the same block argument?

@tblah I gave this a try. But the problem is that not all `private` operands required a `map`. So, for the `private` operand range, we have to construct a corresponding range where we can represent that some of the elements might be missing. This is not possible to with another operand range (i.e. `Varadic<OpenMP_PointerLikeType>` as you suggest) if we represent the `private` input data as individual arrays like we do now (i.e. `Variadic<AnyType>:$private_vars`, `OptionalAttr<SymbolRefArrayAttr>:$private_syms`). This is because some of the values of that new range will have to filled as empty values. The index array attribute gives that by using an index value that does not make sense to be an index like `-1`.

https://github.com/llvm/llvm-project/pull/116770