[Mlir-commits] [mlir] [MLIR][AMDGPU] Add OCP FP8 support for new hardware (PR #106160)

Eric Kunze llvmlistbot at llvm.org
Wed Nov 20 15:46:11 PST 2024


================
@@ -509,7 +509,8 @@ bool TosaValidation::isValidElementType(Type type) {
   if (isa<FloatType>(type)) {
     if (profile == TosaProfileEnum::BaseInference)
       return false;
-    return type.isF32() || type.isF16() || type.isBF16();
----------------
eric-k256 wrote:

The TOSA spec only supports the OCP versions of the FP8 formats, and this pass is verifying adherence to the spec, so we should only add the Float8E4M3FNType and Float8E5M2Type in this location. 

https://github.com/llvm/llvm-project/pull/106160


More information about the Mlir-commits mailing list