[Mlir-commits] [mlir] [MLIR] Implement emulation of static indexing subbyte type vector stores (PR #115922)

Han-Chung Wang llvmlistbot at llvm.org
Wed Nov 20 10:59:42 PST 2024


https://github.com/hanhanW requested changes to this pull request.

Thanks @lialan for the patch. Here is the first round of review comments. I haven't finished the review of the three steps yet, but the idea looks good to me. I mostly want to clarify my understanding on `atomicStore` cases, and I'll review the rest later.

-----

A global comment: can we declare something like `using VectorValue = TypedValue<VectorType>;` in global, so you can use it everywhere in the file?

https://github.com/llvm/llvm-project/pull/115922


More information about the Mlir-commits mailing list