[Mlir-commits] [mlir] [mlir][Vector] Add support for 0-d shapes in extract-shape_cast folder (PR #116650)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> Thanks!
> 
> Just for viz., I was planning to send an RFC (EOW or ENW) to remove support for 0-D vectors from the vector type. The number of bugs we are dealing with and special-casing we are introducing to support 0-D vectors is not worth the value they bring (which it's still unclear to me). So, if you have any specific concerns about that idea, it would be great to know sooner than later (Discord?) :)

We can discuss on the RFC, but I think we need to have support for 0D vector. Without that the system doesnt seem to be closed. For example, tensor and memrefs allow 0D vectors, but having vectors being an outlier and not supporting 0D vector seems like a gap. We are having 0D vector issues because of it being supported patchily. Having fully rounded support and effective handling of 0D vector on lowering to LLVM is a better end state.

https://github.com/llvm/llvm-project/pull/116650