[Mlir-commits] [mlir] [MLIR] Move warp_execute_on_lane_0 from vector to gpu (PR #116994)
Petr Kurapov
llvmlistbot at llvm.org
Wed Nov 20 09:06:15 PST 2024
================
@@ -1097,6 +1097,10 @@ def GPU_YieldOp : GPU_Op<"yield", [Pure, ReturnLike, Terminator]>,
```
}];
+ let builders = [
+ OpBuilder<(ins), [{ /* nothing to do */ }]>
+ ];
+
----------------
kurapov-peter wrote:
Maybe? I had to add it to resolve some missing default constructors, and used the same approach as in `GPU_ReturnOp` and `Vector_YieldOp`, assuming they are empty for a reason. Looking at it now, it should be equivalent, but you're right. I think that would be the correct way of doing it to not have problems if things change. I can submit a patch for all such cases separately.
https://github.com/llvm/llvm-project/pull/116994
More information about the Mlir-commits
mailing list