[Mlir-commits] [mlir] Fix GCC build problem with 288f05f related to SmallVector. (PR #116958)

Andrzej WarzyƄski llvmlistbot at llvm.org
Wed Nov 20 05:04:46 PST 2024


https://github.com/banach-space approved this pull request.

LGTM, thanks!

Just a small nit :) Dumping a full log from your shell into a Git commit summary can make it hard to parse and less helpful. Could you make it a bit more concise and selective? For example, IMHO, this trimmed version of your log would be sufficient:
```bash
/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:3468:10: error: could not convert 'indexingMaps' from 'SmallVector<[...],3>' to 'SmallVector<[...],6>'
3468 | return indexingMaps;
| ^~~~~~~~~~~~
| |
| SmallVector<[...],3>
```

Including a link to the failing bot and the GCC version where this occurs would also be very helpful for context.

Lastly, if no bot is currently failing, it might indicate a gap in our testing. Do you think we should add coverage for this scenario?

https://github.com/llvm/llvm-project/pull/116958


More information about the Mlir-commits mailing list