[Mlir-commits] [flang] [mlir] [mlir][OpenMP] Annotate `private` vars with `map_idx` when needed (PR #116770)
Tom Eccles
llvmlistbot at llvm.org
Wed Nov 20 03:11:34 PST 2024
https://github.com/tblah commented:
Does this have to be an index? What if this was modeled as another reference to the same block argument? Everything is de-duplicated in the mlir context anyway. That would remove any risk of getting out of sync between indexes and arguments. So instead of having an array of integer attributes I think you could have a `Varadic<OpenMP_PointerLikeType>` - this is just a suggestion.
I also left some comments on the interface for this on the other PR, because I think it is easier to discuss where you can see how it is used.
https://github.com/llvm/llvm-project/pull/116770
More information about the Mlir-commits
mailing list