[Mlir-commits] [mlir] 68b7ab1 - [MLIR] Fully qualify entities in the ::mlir namespace in TilingInterface.td. (#116765)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Nov 19 11:16:40 PST 2024
Author: ddubov100
Date: 2024-11-19T20:16:35+01:00
New Revision: 68b7ab127f580bdc422c0dde4bfcd4a2daaeb630
URL: https://github.com/llvm/llvm-project/commit/68b7ab127f580bdc422c0dde4bfcd4a2daaeb630
DIFF: https://github.com/llvm/llvm-project/commit/68b7ab127f580bdc422c0dde4bfcd4a2daaeb630.diff
LOG: [MLIR] Fully qualify entities in the ::mlir namespace in TilingInterface.td. (#116765)
Adding mlir namespace to TilingInterface.td.
Otherwise it can't be used with dialects not nested under the mlir
namespace.
Added:
Modified:
mlir/include/mlir/Interfaces/TilingInterface.td
Removed:
################################################################################
diff --git a/mlir/include/mlir/Interfaces/TilingInterface.td b/mlir/include/mlir/Interfaces/TilingInterface.td
index 4868dad9e1be11..68d4bf7c17e181 100644
--- a/mlir/include/mlir/Interfaces/TilingInterface.td
+++ b/mlir/include/mlir/Interfaces/TilingInterface.td
@@ -66,7 +66,7 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*desc=*/[{
Returns a list of iterator types that describe the number of loops.
}],
- /*retType=*/"SmallVector<utils::IteratorType>",
+ /*retType=*/"::mlir::SmallVector<utils::IteratorType>",
/*methodName=*/"getLoopIteratorTypes",
/*args=*/(ins),
/*methodBody=*/"",
@@ -77,9 +77,9 @@ def TilingInterface : OpInterface<"TilingInterface"> {
Returns a list of ranges that describe the loop bounds and
step for the loops of the operation.
}],
- /*retTy=*/"SmallVector<Range>",
+ /*retTy=*/"::mlir::SmallVector<::mlir::Range>",
/*methodName=*/"getIterationDomain",
- /*args=*/(ins "OpBuilder &":$b),
+ /*args=*/(ins "::mlir::OpBuilder &":$b),
/*methodBody=*/"",
/*defaultImplementation=*/"return {};"
>,
@@ -104,12 +104,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
untiled operation, a `Value` that is the result of the tiled
operation.
}],
- /*retType=*/"FailureOr<::mlir::TilingResult>",
+ /*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
/*methodName=*/"getTiledImplementation",
/*args=*/(ins
- "OpBuilder &":$b,
- "ArrayRef<OpFoldResult> ":$offsets,
- "ArrayRef<OpFoldResult> ":$sizes),
+ "::mlir::OpBuilder &":$b,
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return {};
@@ -149,12 +149,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*retType=*/"::llvm::LogicalResult",
/*methodName=*/"getResultTilePosition",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"unsigned":$resultNumber,
- "ArrayRef<OpFoldResult> ":$offsets,
- "ArrayRef<OpFoldResult> ":$sizes,
- "SmallVector<OpFoldResult> &":$resultOffsets,
- "SmallVector<OpFoldResult> &":$resultSizes),
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
+ "::mlir::SmallVector<::mlir::OpFoldResult> &":$resultOffsets,
+ "::mlir::SmallVector<::mlir::OpFoldResult> &":$resultSizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -187,13 +187,13 @@ def TilingInterface : OpInterface<"TilingInterface"> {
used in the consumer to access). This is upto the caller to handle
appropriately.
}],
- /*retType=*/"FailureOr<::mlir::TilingResult>",
+ /*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
/*methodName=*/"generateResultTileValue",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"unsigned":$resultNumber,
- "ArrayRef<OpFoldResult>":$offsets,
- "ArrayRef<OpFoldResult>":$sizes),
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -217,13 +217,13 @@ def TilingInterface : OpInterface<"TilingInterface"> {
If it is illegal to fuse with a producer along the given operand for
an operation, the implementation should return a failure.
}],
- /*retType=*/"FailureOr<::mlir::TilingResult>",
+ /*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
/*methodName=*/"getTiledImplementationFromOperandTile",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"unsigned":$operandNumber,
- "ArrayRef<OpFoldResult>":$offsets,
- "ArrayRef<OpFoldResult>":$sizes),
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -292,12 +292,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*retType=*/"::llvm::LogicalResult",
/*methodName=*/"getIterationDomainTileFromOperandTile",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"unsigned":$operandNumber,
- "ArrayRef<OpFoldResult> ":$offsets,
- "ArrayRef<OpFoldResult> ":$sizes,
- "SmallVectorImpl<OpFoldResult> &":$iterDomainOffsets,
- "SmallVectorImpl<OpFoldResult> &":$iterDomainSizes),
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
+ "::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainOffsets,
+ "::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainSizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -327,12 +327,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*retType=*/"::llvm::LogicalResult",
/*methodName=*/"getIterationDomainTileFromResultTile",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"unsigned":$resultNumber,
- "ArrayRef<OpFoldResult> ":$offsets,
- "ArrayRef<OpFoldResult> ":$sizes,
- "SmallVectorImpl<OpFoldResult> &":$iterDomainOffsets,
- "SmallVectorImpl<OpFoldResult> &":$iterDomainSizes),
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
+ "::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainOffsets,
+ "::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainSizes),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -352,7 +352,7 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*retType=*/"::llvm::LogicalResult",
/*methodName=*/"generateScalarImplementation",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"Location ":$loc,
"ValueRange ":$ivs),
/*methodBody=*/"",
@@ -377,13 +377,13 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
operation reduction. The tensor shape is equal to operation result
shape with new dimension for each non zero tile size.
}],
- /*retType=*/"FailureOr<SmallVector<Value>>",
+ /*retType=*/"::mlir::FailureOr<SmallVector<Value>>",
/*methodName=*/"generateInitialTensorForPartialReduction",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"Location":$loc,
- "ArrayRef<OpFoldResult>":$sizes,
- "ArrayRef<int>":$reductionDim),
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes,
+ "::mlir::ArrayRef<int>":$reductionDim),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -396,15 +396,15 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
less or equal to the tile size. This is meant to be used with
`mergeReductions` method which will combine the partial reductions.
}],
- /*retType=*/"FailureOr<TilingResult>",
+ /*retType=*/"::mlir::FailureOr<TilingResult>",
/*methodName=*/"tileToPartialReduction",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"Location ":$loc,
"ValueRange":$init,
- "ArrayRef<OpFoldResult>":$offsets,
- "ArrayRef<OpFoldResult>":$sizes,
- "ArrayRef<int>":$reductionDims),
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
+ "::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes,
+ "::mlir::ArrayRef<int>":$reductionDims),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
@@ -416,13 +416,13 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
tiled along the reduction dimensions. This will only apply the
reduction the operation.
}],
- /*retType=*/"FailureOr<MergeResult>",
+ /*retType=*/"::mlir::FailureOr<MergeResult>",
/*methodName=*/"mergeReductions",
/*args=*/(ins
- "OpBuilder &":$b,
+ "::mlir::OpBuilder &":$b,
"Location ":$loc,
"ValueRange":$partialReduce,
- "ArrayRef<int>":$reductionDim),
+ "::mlir::ArrayRef<int>":$reductionDim),
/*methodBody=*/"",
/*defaultImplementation=*/[{
return failure();
More information about the Mlir-commits
mailing list