[Mlir-commits] [mlir] [mlir][linalg][nfc] Update pack-dynamic-inner-tile.mlir (PR #116788)

[Andrzej Warzyński]

================
@@ -84,12 +82,30 @@ func.func private @pack(%A: tensor<7x16xi32>) {
 }
 
 module @transforms attributes { transform.with_named_sequence } {
-  transform.named_sequence @__transform_main(%module: !transform.any_op {transform.readonly}) {
+  transform.named_sequence @__transform_main(%module: !transform.any_op {transform.consume}) {
     %pack = transform.structured.match ops{["tensor.pack"]} in %module : (!transform.any_op) -> !transform.any_op
 
-    %tiled_linalg_op_p, %loops:2 = transform.structured.tile_using_for %pack tile_sizes [1, 1]
+    // 1. Tile so that we can decompose tensor.pack into tensor.pad,
+    // linalg.transpose, etc (see step 2).
----------------
banach-space wrote:

This is a valid request - thank you for bringing it up, and please don’t hesitate to ask in the future. I've been working on this for so long that I may have lost perspective on what's obvious versus what could use more explanation.

I've added some additional comments to clarify what’s happening here. I’ve intentionally skipped some finer details to keep the explanation focused and easier to follow.

https://github.com/llvm/llvm-project/pull/116788