[Mlir-commits] [mlir] [mlir][OpenMP] inscan reduction modifier and scan op mlir support (PR #114737)

Michael Klemm llvmlistbot at llvm.org
Mon Nov 18 14:19:21 PST 2024


================
@@ -178,6 +178,27 @@ def OrderModifier
 def OrderModifierAttr : EnumAttr<OpenMP_Dialect, OrderModifier,
                                     "order_mod">;
 
+//===----------------------------------------------------------------------===//
+// reduction_modifier enum.
+//===----------------------------------------------------------------------===//
+
+def ReductionModifierInScan : I32EnumAttrCase<"InScan", 0>;
+def ReductionModifierTask : I32EnumAttrCase<"Task", 1>;
+def ReductionModifierDefault : I32EnumAttrCase<"Default", 2>;
+
----------------
mjklemm wrote:

Is there a particular reason why default is 2 and not 0.  The OpenMP specification lists them in this order: `default`, `inscan`, `task`.  So, maybe also go with this order?

https://github.com/llvm/llvm-project/pull/114737


More information about the Mlir-commits mailing list