[Mlir-commits] [mlir] [mlir] Add description to amdgpu.dpp and rocdl.update.dpp (PR #116598)

Lei Zhang llvmlistbot at llvm.org
Mon Nov 18 09:42:45 PST 2024


================
@@ -621,6 +621,15 @@ def ROCDL_DPPUpdateOp : ROCDL_IntrOp<"update.dpp", [], [0],
   Arguments<(ins LLVM_Type:$old, LLVM_Type:$src, I32Attr:$dppCtrl, I32Attr:$rowMask,
       I32Attr:$bankMask, I1Attr:$boundCtrl)> {
   let results = (outs LLVM_Type:$res);
+  let summary = "Represent the DPP(Data-Parallel Primitives) functionality";
+  let description = [{
+    Represent the DPP(Data-Parallel Primitives) functionality,
----------------
antiagainst wrote:

Typically don't repeat what you have said in `summary`. Just give more explanation. Something like "This op maps to DPP (data parallel primitive) instrinsics. It alows threads in the same subgroup to exchange data in their registers directly, following very specific exchange patterns. [and then explain in detail about the semantics..]"

https://github.com/llvm/llvm-project/pull/116598


More information about the Mlir-commits mailing list