[Mlir-commits] [llvm] [mlir] [llvm][OpenMP] Add implicit cast to omp.atomic.read (PR #114659)

[llvmlistbot at llvm.org]

NimishMishra wrote:

> I added `emitAtomicLoadBuiltin` and `emitAtomicStoreBuiltin` into #101966, and use it within OpenMPIRBuilder. The patch is not ready yet, tests are not updated, tits probably not yet completely correct, and code duplication needs to be reduced.


Thanks for your work on this. I went through the patch, and it does seem this approach is better. I see this PR can also help with sized libcalls. 

I wonder whether work on this needs a separate PR, or whether we can merge with the current PR? Since, it is more generic and solves multiple issues at once. I am okay with picking this work and opening a new PR, where we can discuss improvements and iterate over it. Let me know what you think.

https://github.com/llvm/llvm-project/pull/114659