[Mlir-commits] [mlir] [MLIR] RemoveDeadValues: Allowing IRs with global constants to get dead values removed (PR #116519)

[Perry Gibson]

https://github.com/Wheest commented:

>From my perspective it should be fine if IR with named symbols like constants use this pass (my recent PR did this for named modules #109990).

A justification for keeping the existing behaviour could be: "that which has a name should be handled more carefully, and not removed unless specifically requested."

However, since this is a blocker for some of my own work, I don't support it, and think this PR should go through.

That being said, I could imagine adding this behaviour back in with `--remove-dead-values="remove-user-symbols"`


https://github.com/llvm/llvm-project/pull/116519