[Mlir-commits] [mlir] [NFC][MLIR][Linalg] Refactor linalg.matmul tablegen ODS and related C++ code. (PR #116377)

[Kunwar Grover]

================
@@ -222,9 +214,6 @@ buildMatmulOp(OpBuilder &b, OperationState &state,
       indexingMapsAttrVal.push_back(AffineMapAttr::get(map));
     }
     state.addAttribute("indexing_maps", b.getArrayAttr(indexingMapsAttrVal));
-  } else {
-    indexingMapsAttrVal = getDefaultMatmulIndexingMapAttr(b.getContext());
-    state.addAttribute("indexing_maps", b.getArrayAttr(indexingMapsAttrVal));
----------------
Groverkss wrote:

It looks like you're expecting the indexingMaps array ref to always have a value. Can you make the indexingMaps argument not optional? It seems weird you can build a matmul op with no indexing maps.

https://github.com/llvm/llvm-project/pull/116377