[Mlir-commits] [mlir] [mlir][CallGraph] Fix abstract edge connected to external node (PR #116177)

[Haocong Lu]

Luhaocong wrote:

> Yes, I echo the same comments as @zero9178. This doesn't look correct to me generally, a function being public isn't the only indication something can be referenced externally. Non-symbol callables could be called externally, so could symbols with their address taken. To be able to answer that question for symbol operations you'd need a deeper analysis of the program state (i.e. seeing what things reference the symbol and possibly how they reference it)

Thanks for your professional guidance @zero9178 @River707 . I will refer to the analysis in `struct CGUseList` and LLVM's implements, then try building a more complete CallGraph.

https://github.com/llvm/llvm-project/pull/116177