[Mlir-commits] [mlir] [MLIR] Add callback functions for ModuleToObject (PR #116007)

Zichen Lu llvmlistbot at llvm.org
Sun Nov 17 18:45:08 PST 2024


================
@@ -572,6 +572,9 @@ NVPTXSerializer::moduleToObject(llvm::Module &llvmModule) {
     getOperation().emitError() << "Failed translating the module to ISA.";
     return std::nullopt;
   }
+  if (isaCallback) {
----------------
MikaOvO wrote:

> This means code replication. This path calls nvdisasm on cubin and print sass. I think it's better to leverage this mechanism, and all the downstream compilers use it.

I think you are right. But in my current understanding, `sass` is a concept that only exists in `nvvm`. So we can not name a callback `sassCallBack`. Similarly, we cannot name a callback `ptxCallback`, but we can name it `isaCallback`.
 

https://github.com/llvm/llvm-project/pull/116007


More information about the Mlir-commits mailing list